-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make debug fail #5225
Comments
Thanks. Assertions are only enabled in debug mode. This is my fault; fix on the way. |
Thanks for the quick fix. Could I suggest changing Travis to On Mon, Dec 23, 2013 at 9:27 AM, Jeff Bezanson notifications@github.comwrote:
Michael |
Travis should maybe use a debug build, but why should the nightlies be debug builds? |
Because other projects using Travis checkout the nightlies and when your On Mon, Dec 23, 2013 at 10:16 AM, Stefan Karpinski <notifications@github.com
Michael |
I mean, it could build both, right? So people just wanting to use nightlies On Mon, Dec 23, 2013 at 11:09 AM, Michael Fox 415fox@gmail.com wrote:
Michael |
* upstream/master: (89 commits) fix JuliaLang#5225 update pcre fix off-by-1 in isqrt. closes JuliaLang#4884 Add more keywords to ctags regex, plus README annotate the types of arguments for derived trigonometric & hyperbolic functions fix doc for && and || and update helpdb only show ccall literal address warning in imaging mode. closes JuliaLang#5215 minor update of hypot to ensure consistency of output types Fix JuliaLang#5217 silence compiler warning hopefully more robust way of getting github URL (don't assume module name is Pkg name) add text/html writemime for MethodList and Method (fix JuliaLang#4952) update NEWS doc: `import M: single,name` syntax, close JuliaLang#5214 clean up native finalizers code specialized abs2 for bool remove use of callback API in REPL Some error message cleanup to fix segfault when transposing sparse vector with illegal values. test/git*.jl: don't use `echo` to read-and-write from processes. test/git*.jl: don't use `echo` to read-and-write from processes. ...
Also, people who are using nightlies are asking for trouble. They're going On Mon, Dec 23, 2013 at 11:10 AM, Michael Fox 415fox@gmail.com wrote:
Michael |
Oh, including it is certainly totally fine. I just worry about the inevitable performance complaints if we make a debug build the default. |
It will significantly increase the install size. I guess it's ok for nightlies, but not in released versions. It is not normal practice to install both debug and release versions. |
That's a reasonable distinction. |
But consider this: I'm a new user. I do something very unexpected during On Mon, Dec 23, 2013 at 1:32 PM, Jeff Bezanson notifications@github.comwrote:
Michael |
You don't need the debug build to open an issue. I never use the debug build. |
I think he means that you want to file an issue with a backtrace. I have to say that I think that needing a backtrace is pretty uncommon. |
I agree. My point was that many issues get filed without backtraces. It's a little hard for me to believe that a new user arrives, finds a bug that can only be explained with reference to a backtrace, finds they don't have the debug build and then abandons Julia forever. |
If there are steps that reproduce the problem, we can take care of the rest. Not everybody needs the debug build. I don't seem to have |
You could: On Mon, Dec 23, 2013 at 2:05 PM, Jeff Bezanson notifications@github.comwrote:
Michael |
Yes but it's not the default. |
So we agree then? It should convenient but not default. If there's a On Mon, Dec 23, 2013 at 2:44 PM, Jeff Bezanson notifications@github.comwrote:
Michael |
That leaves the question of what to do with OSX and Windows. OSX is easy because Mac users are accustomed to 400MB For Windows I'll make an InstallShield Wizard that demands the user accept On Mon, Dec 23, 2013 at 3:03 PM, Michael Fox 415fox@gmail.com wrote:
Michael |
Don't forget to make sure it makes a shortcut link to start Julia on your desktop. |
And don't make the mistake of simply putting the julia shortcut in the Startup Items folder where users can easily delete it. Surely there is a more robust way to ensure that julia runs on startup. |
I'm not sure whether I need to
make debug
to have debug symbols, but anyway, I tried it onv0.2.0
on Ubuntu 12.04 and got this:This doesn't happen with
make
.Update: Apparently you don't get debug symbols if you just
make
.Update: I can
make julia-debug
and it even runs but at some point -- before I get to the crash I actually want to trace -- it does this:Which is the same thing I guess. Backtrace:
The text was updated successfully, but these errors were encountered: