Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

segfault in gc binarytree.jl test #52757

Closed
vtjnash opened this issue Jan 5, 2024 · 1 comment
Closed

segfault in gc binarytree.jl test #52757

vtjnash opened this issue Jan 5, 2024 · 1 comment
Assignees
@d-netto
Labels
domain:ci Continuous integration kind:rr trace included

Comments

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jan 5, 2024 

gc                                                (1) |        started at 2024-01-04T13:38:07.111 on pid 533
[8487] signal 11 (1): Segmentation fault
in expression starting at /cache/build/tester-amdci4-8/julialang/julia-master/julia-6779fa96e4/share/julia/test/gc/binarytree.jl:53
jl_datatype_layout at /cache/build/builder-amdci5-4/julialang/julia-master/src/julia.h:1328 [inlined]
immut_id_ at /cache/build/builder-amdci5-4/julialang/julia-master/src/builtins.c:393
jl_idset_peek_bp at /cache/build/builder-amdci5-4/julialang/julia-master/src/idset.c:34
gc                                                (1) |         failed at 2024-01-04T13:39:02.947

https://buildkite.com/julialang/julia-master/builds/31785#018cd431-1edc-46d7-ad8a-6669680d7607 (@d-netto)
@vtjnash vtjnash added domain:ci Continuous integration kind:rr trace included labels Jan 5, 2024
@d-netto d-netto self-assigned this Jan 5, 2024
@vtjnash vtjnash mentioned this issue Feb 7, 2024
Closed
@vtjnash
Copy link
Sponsor Member Author

vtjnash commented Feb 13, 2024

More binarytree trouble, this time with both an rr trace and then a heap corruption notice https://buildkite.com/julialang/julia-master/builds/33576#_

This was referenced Feb 15, 2024
Closed
Closed
KristofferC pushed a commit that referenced this issue Feb 26, 2024
@gbaraldi @KristofferC
Fix synchronization issue on the GC scheduler (#53355)
06e52c5 
This aims to slightly simplify the synchronization by making
`n_threads_marking` the sole memory location of relevance for it, it
also removes the fast path, because being protected by the lock is
quite important so that the observed gc state arrays are valid.

Fixes: #53350
Fixes: #52757
Maybe fixes: #53026
Co-authored-by: Jameson Nash <vtjnash@gmail.com>

(cherry picked from commit a96726b)
tecosaur pushed a commit to tecosaur/julia that referenced this issue Mar 4, 2024
@gbaraldi @vtjnash @tecosaur
Fix synchronization issue on the GC scheduler (JuliaLang#53355)
308176a 
This aims to slightly simplify the synchronization by making
`n_threads_marking` the sole memory location of relevance for it, it
also removes the fast path, because being protected by the lock is
quite important so that the observed gc state arrays are valid.

Fixes: JuliaLang#53350
Fixes: JuliaLang#52757
Maybe fixes: JuliaLang#53026
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
mkitti pushed a commit to mkitti/julia that referenced this issue Mar 7, 2024
@gbaraldi @vtjnash @mkitti
Fix synchronization issue on the GC scheduler (JuliaLang#53355)
609d131 
This aims to slightly simplify the synchronization by making
`n_threads_marking` the sole memory location of relevance for it, it
also removes the fast path, because being protected by the lock is
quite important so that the observed gc state arrays are valid.

Fixes: JuliaLang#53350
Fixes: JuliaLang#52757
Maybe fixes: JuliaLang#53026
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d-netto d-netto

Labels
domain:ci Continuous integration kind:rr trace included
Projects
None yet
Milestone
No milestone
2 participants
@vtjnash @d-netto