Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segfault in jl_emit_codeinst #53811

Closed
d-netto opened this issue Mar 21, 2024 · 1 comment · Fixed by #53809
Closed

Segfault in jl_emit_codeinst #53811

d-netto opened this issue Mar 21, 2024 · 1 comment · Fixed by #53809
Labels
domain:ci Continuous integration kind:bug Indicates an unexpected problem or unintended behavior system:apple silicon Affects Apple Silicon only (Darwin/ARM64) - e.g. M1 and other M-series chips

Comments

@d-netto
Copy link
Member

d-netto commented Mar 21, 2024

Seen it here: https://buildkite.com/julialang/julia-master/builds/34864#018e60ec-1109-4fb1-a6b9-7a593afa7ea6.

I'm also to reproduce it locally by running Base.runtests().
@d-netto d-netto added kind:bug Indicates an unexpected problem or unintended behavior domain:ci Continuous integration labels Mar 21, 2024
@gbaraldi gbaraldi mentioned this issue Mar 21, 2024
Merged
Keno pushed a commit that referenced this issue Mar 22, 2024
@gbaraldi
Add missing GC_POP() in emit_cfunction (#53809)
52fc796 
~~Apparently somewhere in codegen inside `emit_codeinst`some piece of
code is relying on the implicit try catch gcstack restoring. I haven't
got the analyzer working on that file yet (it has hundreds of issues and
it doesn't like C++ code that much + the file is tens of thousands of
lines after includes so it struggles).~~

This fixes the compileall segfault in apple-aarch64 ci.
#53811
@giordano
Copy link
Contributor

Fixed by #53809.

@giordano giordano added the system:apple silicon Affects Apple Silicon only (Darwin/ARM64) - e.g. M1 and other M-series chips label Mar 22, 2024
@giordano giordano mentioned this issue Mar 22, 2024
Closed
KristofferC pushed a commit that referenced this issue Mar 27, 2024
@gbaraldi
Add missing GC_POP() in emit_cfunction (#53809)
0a7a95c 
~~Apparently somewhere in codegen inside `emit_codeinst`some piece of
code is relying on the implicit try catch gcstack restoring. I haven't
got the analyzer working on that file yet (it has hundreds of issues and
it doesn't like C++ code that much + the file is tens of thousands of
lines after includes so it struggles).~~

This fixes the compileall segfault in apple-aarch64 ci.
#53811

(cherry picked from commit 52fc796)
KristofferC pushed a commit that referenced this issue Mar 27, 2024
@gbaraldi
Add missing GC_POP() in emit_cfunction (#53809)
e44f1ab 
~~Apparently somewhere in codegen inside `emit_codeinst`some piece of
code is relying on the implicit try catch gcstack restoring. I haven't
got the analyzer working on that file yet (it has hundreds of issues and
it doesn't like C++ code that much + the file is tens of thousands of
lines after includes so it struggles).~~

This fixes the compileall segfault in apple-aarch64 ci.
#53811

(cherry picked from commit 52fc796)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain:ci Continuous integration kind:bug Indicates an unexpected problem or unintended behavior system:apple silicon Affects Apple Silicon only (Darwin/ARM64) - e.g. M1 and other M-series chips
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing GC_POP() in emit_cfunction JuliaLang/julia
2 participants
@giordano @d-netto