Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pivoting to LU decomposition. #5430

Merged
merged 1 commit into from
Jan 18, 2014
Merged

Add pivoting to LU decomposition. #5430

merged 1 commit into from
Jan 18, 2014

Conversation

andreasnoack
Copy link
Member

To avoid absurdity and craziness.

@jiahao
Copy link
Member

jiahao commented Jan 17, 2014

Would you like to come postdoc with me? ;)

@andreasnoack
Copy link
Member Author

Definately

@jiahao
Copy link
Member

jiahao commented Jan 17, 2014

I'll talk to @alanedelman. I think we can make it happen.

@stevengj
Copy link
Member

Thanks for taking care of this so quickly, @andreasnoackjensen.

@JeffBezanson
Copy link
Sponsor Member

Is there any reason not to merge this now?

@IainNZ
Copy link
Member

IainNZ commented Jan 18, 2014

This series of commits on this stuff is reminding me of my undergrad computational techniques class, should go back and tell my professors to use Julia and not force non-computer savvy 2nd year engineering students to implement LU with pivots in C!

@andreasnoack
Copy link
Member Author

@jiahao I took a closer look at dgetf2 and it "finishes" the decomposition even when a pivot is detected to be zero. I am not sure why they have chosen to do so, but thought the safe solution here was to mimic LAPACK.

@jiahao
Copy link
Member

jiahao commented Jan 18, 2014

It makes sense to me now after thinking about it. A singular matrix can have a valid LU decomposition; it is merely not unique.

jiahao added a commit that referenced this pull request Jan 18, 2014
Add pivoting to LU decomposition.
@jiahao jiahao merged commit d2f501d into master Jan 18, 2014
@andreasnoack andreasnoack deleted the anj/lup branch January 18, 2014 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants