-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pkg.submit suggestions #7820
Comments
Maybe also look warn if there are uncommitted changes. |
Here is a more complete sketch of what I think would be useful to git novices. I may have gotten the git best practices wrong. Also since
Best practice is to create a feature branch before you make any changes.
Then make your changes, including adding relevant test cases in to
If you have already made changes, the workflow is slightly different.
If there are conflicts during the rebase fix them then Once you have submitted your pull request, you may be asked to make further modifications before it is accepted. |
These are good suggestions – thanks! |
I can't seem to find any documentation for |
See #6986. |
Moved to PkgDev.jl |
First, Pkg.submit is pretty cool, I just used it to submit a pull request to HDF5.jl. It definitely easier to approach for the non-expert than figuring out how to fork and sync my changes with github myself. That said, it took me a few tries to realize that 1. I need to commit my changes (yes this is obvious, but hey I'm not that good at this) 2. what to do about it. The current behavior has you looking at an empty pull request when you haven't committed your changes locally.
My recommendation is for submit to look at the current branch, and it is in the default detached HEAD state, to print out some guidance like. Perhaps something like the following:
Before submitting a pull request you must commit your changes. Try "checkout -b newbranch" followed by "git add ." and "git commit -m "some useful commit message".
It would also be nice if it set up your branch such that
git push
pushes to the pull request branch that submit had created on github for easily updating that pull request.The text was updated successfully, but these errors were encountered: