Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do much the same for libstdc++ as we do for libgfortran on Linux #10043

Merged
merged 1 commit into from Feb 3, 2015

Conversation

staticfloat
Copy link
Sponsor Member

This distributes the system libstdc++.so.X alongside Julia when you make dist.

@tkelman

@tkelman
Copy link
Contributor

tkelman commented Feb 3, 2015

Background for anyone who wasn't following along in #8442 - the devtoolset gcc we had been using on the centos 5 buildbots to create generic linux binary tarballs (used on Travis for language: julia, and convenient on distributions that don't have Julia packaged, or for testing nightlies) does some strange packaging of libgfortran and libstdc++. We were accidentally including a libgfortran from centos 5's system gcc 4.1.2 in the binaries, which breaks a lot of packages that have Fortran dependencies. (It's a little surprising that base Julia's Fortran dependencies were working at all.)

So we need to build our own gcc on the buildbots, which is now done, and also bundle libstdc++ (this pr).

If someone were to use clang or libc++, I think this would be a no-op, right? And I don't think distribution packagers are using make dist so this doesn't change anything there.

@staticfloat
Copy link
Sponsor Member Author

Yep. The script will probably print something nebulous out like "basename: argument required", but if it fails, things just continue on their merry way.

@ViralBShah
Copy link
Member

Bundling libstdc++ is much needed! Thanks.

tkelman added a commit that referenced this pull request Feb 3, 2015
Do much the same for libstdc++ as we do for libgfortran on Linux
@tkelman tkelman merged commit 3420529 into master Feb 3, 2015
@tkelman tkelman deleted the sf/libstdc++ branch February 3, 2015 20:18
staticfloat added a commit that referenced this pull request Feb 6, 2015
@tkelman
Copy link
Contributor

tkelman commented Feb 6, 2015

backported in d97b3ba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants