Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace number parsing functions with parse and tryparse #10543

Merged
merged 7 commits into from
Mar 17, 2015
Merged

replace number parsing functions with parse and tryparse #10543

merged 7 commits into from
Mar 17, 2015

Commits on Mar 17, 2015

  1. tryparse: parse string to Nullable 

    Introduces the tryparse method:
- tryparse{T<:Integer}(::Type{T<:Integer},s::AbstractString)
- tryparse(::Type{Float..},s::AbstractString)
- a few variants of the above

And:
- tryparse(Float.., ...) call the corresponding C functions jl_try_strtof, jl_try_substrtof, jl_try_strtod and jl_try_substrtod.
- The parseint, parsefloat, float64_isvalid and float32_isvalid methods wrap the corresponding tryparse methods.
- The jl_strtod, jl_strtof, ... functions are wrappers over the jl_try_str... functions.

This should fix #10498 as well.

Ref: discussions at #9316, #3631, #5704
    @tanmaykm
    tanmaykm committed Mar 17, 2015
    10 Configuration menu
    Copy the full SHA
    2c327d3 View commit details
    Browse the repository at this point in the history

  2. deprecate float64_isvalid, float32_isvalid

    @tanmaykm
    tanmaykm committed Mar 17, 2015
    Configuration menu
    Copy the full SHA
    ede4fed View commit details
    Browse the repository at this point in the history

  3. reshuffle combinatorics.jl

    @tanmaykm
    tanmaykm committed Mar 17, 2015
    Configuration menu
    Copy the full SHA
    df239aa View commit details
    Browse the repository at this point in the history

  4. fix formatting, and printing of Nullable 

    [ci skip]
    @JeffBezanson
    JeffBezanson committed Mar 17, 2015
    Configuration menu
    Copy the full SHA
    4751425 View commit details
    Browse the repository at this point in the history

  5. move factorial and binomial again, to locations I prefer 

    I'd rather isolate BigNum code as much as possible
    @JeffBezanson
    JeffBezanson committed Mar 17, 2015
    Configuration menu
    Copy the full SHA
    67a9d5f View commit details
    Browse the repository at this point in the history

  6. replace parseint and parsefloat with parse

    @JeffBezanson
    JeffBezanson committed Mar 17, 2015
    Configuration menu
    Copy the full SHA
    d76e086 View commit details
    Browse the repository at this point in the history

  7. NEWS and doc updates for parse/tryparse 

    [ci skip]
    @JeffBezanson
    JeffBezanson committed Mar 17, 2015
    Configuration menu
    Copy the full SHA
    9e1cc7f View commit details
    Browse the repository at this point in the history