RFC: Clean up references to LLVM < 3.3 #10976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrison
changed the title
|
I did a second visual inspection and everything looks correct to me. I've also been able to get all tests to pass locally on LLVM 3.3, 3.5, and 3.6. |
garrison
changed the title
|
LGTM. |
JeffBezanson
added a commit
that referenced
this pull request
Apr 25, 2015
RFC: Clean up references to LLVM < 3.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Sorry, hit enter too soon as I was typing this]
I believe this is what @tkelman was referring to here.
I'd still like to double check everything before this gets merged.The obvious downside of merging this is that is may lead to some merge conflicts here and there.