RFC: Speed up Pkg.update() #11137
Merged
RFC: Speed up Pkg.update() #11137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,6 +58,10 @@ attached(; dir="") = success(`symbolic-ref -q HEAD`, dir=dir) | |||
| branch(; dir="") = readchomp(`rev-parse --symbolic-full-name --abbrev-ref HEAD`, dir=dir) | |||
| head(; dir="") = readchomp(`rev-parse HEAD`, dir=dir) | |||
|
|
|||
| function iscommit(sha1s::Array{ASCIIString}; dir="") | |||
| indexin(sha1s,split(readchomp(`log --all --format=%H`, dir=dir),"\n")).!=0 | |||
There was a problem hiding this comment.
Can you check whether the latest versions of git, 2.3, 2.4 etc still accept --format ? The docs for recent versions are a bit ambiguous.
There was a problem hiding this comment.
--format still works for me on 2.4.0.
There was a problem hiding this comment.
Yes, 2.4.0 seems to behave the same way as the older version I've been using.
|
+1 – good approach if this works for all various versions of git |
…) and using it in Cache.prefetch().
|
I made some minor cleanups and rebased. I removed the unnecessary |
jakebolewski
added a commit
that referenced
this pull request
May 6, 2015
RFC: Speed up Pkg.update()
|
nominating for potential backport, unless there are objections |
|
backported in a946283 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I get a major speed improvement in
Pkg.update()with this patch. The idea is to usegit log --allto extract all valid hashes instead of callinggiton every single hash. This can be used inCache.prefetch(), which currently makes multiple passes through every version of every installed package.It would probably be good to get some independent testing before merging.
Should improve #9944 somewhat, will eventually be superceded by #7584 (libgit2).