Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #10959 bugs with UTF-16 conversions #11551

Merged
merged 4 commits into from
Jul 1, 2015
Merged

Fix #10959 bugs with UTF-16 conversions #11551

merged 4 commits into from
Jul 1, 2015
+350 −67

Commits on Jun 25, 2015

  1. Fix JuliaLang#10959 bugs with UTF-16 conversions 

    Rewrote a number of the conversions between ASCIIString, UTF8String, and UTF16String.
Rewrote length() for UTF16String().
Improved reverse() for UTF16String().

Added over 150 lines of testing code to detect the above conversion problems

Added (in a gist) code to show other conversion problems not yet fixed:
https://gist.github.com/ScottPJones/4e6e8938f0559998f9fc

Added (in a gist) code to benchmark the performance, to ensure that adding the extra validity
checking did not adversely affect performance (in fact, performance was greatly improved).
https://gist.github.com/ScottPJones/79ed895f05f85f333d84

Updated based on review comments

Changes to error handling and check_string

Rebased against JuliaLang#11575
Updated comment to go before function, not indented by 4

Updated to use unsafe_checkstring

Removed redundant argument documentation
    @ScottPJones
    ScottPJones committed Jun 25, 2015
    1 Configuration menu
    Copy the full SHA
    a286ce0 View commit details
    Browse the repository at this point in the history

  2. Fix AbstractVector{UInt16} conversion

    @ScottPJones
    ScottPJones committed Jun 25, 2015
    Configuration menu
    Copy the full SHA
    a0c273b View commit details
    Browse the repository at this point in the history

  3. Remove support for converting Vector{UInt16} to UTF8String

    @ScottPJones
    ScottPJones committed Jun 25, 2015
    Configuration menu
    Copy the full SHA
    00f0200 View commit details
    Browse the repository at this point in the history

  4. Update UTF16String map function

    @ScottPJones
    ScottPJones committed Jun 25, 2015
    Configuration menu
    Copy the full SHA
    2ab9334 View commit details
    Browse the repository at this point in the history