Move setindex! with Colon from array.jl to arraymath.jl #11678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
force-pushed
the
revert-10331-mb/colon-indexing
branch
from
7dd9716
to
9b24adc
Compare
hopefully fixes win64 inference freeze
tkelman
force-pushed
the
revert-10331-mb/colon-indexing
branch
from
9b24adc
to
2fe0d94
Compare
tkelman
changed the title
4 tasks
|
👍 I like this solution even better. You can totally delete those setindex! methods instead of moving them. Sorry about the failures -- I did double check that things passed locally, so I thought we were good. |
Thanks. So these get defined elsewhere? LLVM 3.3 seems to be especially buggy on win32 and win64, and changes to core bits and pieces have a tendency to find those bugs. |
|
Yeah, they're completely redundant with the abstract fallbacks in multidimensional.jl. |
|
Even better, that'll make this a net deletion of code then, and in the core dependencies of inference too. I'll push that and merge as soon as my tests pass locally. |
|
Thank you Tony! |
tkelman
added a commit
that referenced
this pull request
Jun 12, 2015
Move setindex! with Colon from array.jl to arraymath.jl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #10331Ignore the branch name, I think this should be a fix for #10331 (comment)