More verbose Pkg.update() for checked out packages #11875
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like how "free" packages display which versions they're updating from and to, display the git SHA for checked out packages as they are updated. Here's a real-life example: ```txt julia> Pkg.update() INFO: Updating METADATA... INFO: Updating Interpolations master... INFO: Updating Tuples master... INFO: Skipping TerminalExtensions (dirty)... INFO: Updating AxisArrays master... INFO: Updating Compat master... INFO: Updating IntSets master... INFO: Updating HDF5 master... INFO: Skipping BitSets (dirty)... INFO: Updating DataArrays master... b5d39c3 => c588781 INFO: Skipping Signals (dirty)... INFO: Updating KDTrees master... INFO: Updating FileIO master... INFO: Skipping SmallDicts (dirty)... INFO: Updating BinDeps master... INFO: Updating DataFrames master... INFO: Updating SIUnits master... INFO: Updating Homebrew master... INFO: Computing changes... INFO: No packages to install, update or remove ``` To be honest, I was totally unaware of how many packages I had that were either dirty or happened to be on a custom branch before I made this change (DataArrays is only updating because I had been on a custom branch until I started printing out the branch names). This also prints out the before and after SHA if there was a change.
mbauman
force-pushed
the
mb/verboseupdate
branch
from
fc6ce3c
to
3e3e838
Compare
|
This will slow down update even more. With libgit2 backend it would be faster. I think we should postpone it. Meanwhile, you could look at |
|
Can we measure how much slower? I think this is valuable information, and |
|
|
|
closing in favor of #13648 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like how "free" packages display which versions they're updating from and to, display the git SHA for checked out packages as they are updated. Here's a real-life example:
To be honest, I was totally unaware of how many packages I had that were either dirty or happened to be on a custom branch before I made this change (DataArrays is only updating because I had been on a custom branch until I started printing out the branch names). This also prints out the before and after SHA if there was a change.
It's a small change, but I have no idea how the Pkg code works, so I'd appreciate a slightly more-thorough-than-usual lookover. In particular, I don't know if these git commands are available for our lowest-supported Git version, or what the
@recovermacro does.