Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert manual conversion #11926

Merged
merged 4 commits into from
Jun 29, 2015
Merged

Revert manual conversion #11926

merged 4 commits into from
Jun 29, 2015

Conversation

MikeInnes
Copy link
Member

The last thing I want to do is to anger those who have spent time writing the documentation, and it's clear that these changes have done that, so it seems right to give them the opportunity to undo them.

I can fix things one way or another at this stage (and I certainly don't want to lose anyone's hard work), but if I start from scratch and do everything in one go it may leave things in a less distressing state in the meantime.

@jiahao
Copy link
Member

jiahao commented Jun 29, 2015

I appreciate all the work that you and others have put in toward the doc transition. However, I really do wish that more attention was paid to all the formatting and semantic information that was lost or broken in #11906.

@ViralBShah
Copy link
Member

Thanks Mike for patiently working through this. This is a tough task and yes more attention could be given before merging, but reverting is certainly the right thing to do till all the things are figured out.

@tkelman
Copy link
Contributor

tkelman commented Jun 29, 2015

Agreed. It's great that the doc string syntax was worked out recently, and the tools are almost good enough to make a seamless transition of the doc system, but given the other items on the 0.4 menu I have to say I was really surprised to see so much attention placed here.

@MikeInnes
Copy link
Member Author

Ok, I'll go ahead and merge this.

When I have another go at this I'll make sure it's a completely lossless transition so that it's clear no corners are being cut. Some of the patches (Stefan's work on pulling out the help system, at least) should be fairly easy to reuse.

MikeInnes added a commit that referenced this pull request Jun 29, 2015
@MikeInnes MikeInnes merged commit dcc4596 into master Jun 29, 2015
@MikeInnes MikeInnes deleted the omm/doc-revert branch June 29, 2015 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants