Don't bail out in the binary-dist target, if openblas is not compiled with dynamic arch support #12310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
This can give illegal instruction errors, I'd rather it be louder than a warning. Can we make it non-fatal on |
|
What is the right way to make this non-x86? There's x86_64, i686, and i386. We can also make it non-fatal on ARM only, since openblas doesn't support other architectures. |
|
Ah, you're right, I didn't realize https://github.com/JuliaLang/julia/blob/master/Make.powerpc wasn't using openblas. So ARM only should be good enough, I don't think anyone has tried building on MIPS or anything else exotic. |
|
Turns out that with ISX86, it is easiest to enable dynamic arch on x86 only. |
ViralBShah
pushed a commit
that referenced
this pull request
Jul 26, 2015
Don't bail out in the binary-dist target, if openblas is not compiled with dynamic arch support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not available on ARM, and in any case, it seems ok to
just print a warning.