RFC: always add .jl to non-absolute paths in find_in_path #12356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
deprecated.jl currently passes absolute paths through require as an upgrade path for v0.3 code. the intention with making require accept Symbols instead of Strings was to provide a new API layer that dealt strictly with modules names (files), and did not readily facilitate specification of actual filesystem layout information. |
|
Ah, perfect. So IIUC this change already does the right thing. |
|
Let's try this, see if it works better. |
JeffBezanson
added a commit
that referenced
this pull request
Jul 30, 2015
RFC: always add .jl to non-absolute paths in find_in_path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #12340.
Discussion sought on how to handle absolute paths. My instinct was to leave absolute paths alone, but it also seems slightly odd to add .jl to
a/bbut not to/a/b. However, this function is only used byrequire, so I'm not sure names with slashes are ever passed to it at all, in which case we could remove that code.