Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure to hold the gc-root for the init list while calling __init__ #12399

Merged
merged 1 commit into from Jul 31, 2015

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Jul 31, 2015

No description provided.

@tkelman
Copy link
Contributor

tkelman commented Jul 31, 2015

Is this #12352 (comment)? What's the failure mode?

@vtjnash
Copy link
Sponsor Member Author

vtjnash commented Jul 31, 2015

failure mode would be that the list of modules-to-init gets garbage collected while using it

#12352 turned out to have a misleading backtrace and will be closed by a different PR (#12400)

vtjnash added a commit that referenced this pull request Jul 31, 2015
make sure to hold the gc-root for the init list while calling __init__
@vtjnash vtjnash merged commit 87557c7 into master Jul 31, 2015
@vtjnash vtjnash deleted the jn/gc_root_init branch July 31, 2015 05:47
@tkelman
Copy link
Contributor

tkelman commented Jul 31, 2015

any chance of this being responsible for https://ci.appveyor.com/project/StefanKarpinski/julia/build/1.0.7509/job/vo00m8tqme77hq64, or unrelated?

@vtjnash
Copy link
Sponsor Member Author

vtjnash commented Jul 31, 2015

i don't think that could be related, since this only should be an issue during the execution of the __init__ methods from a .ji file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants