Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Pkg.submit(): GitHub no longer stores OAuth tokens #12607

Merged
merged 1 commit into from Oct 1, 2015
Merged

Fixes Pkg.submit(): GitHub no longer stores OAuth tokens #12607

merged 1 commit into from Oct 1, 2015

Conversation

slundberg
Copy link
Contributor

Pkg.submit() currently fails if a user has previously created a GitHub Julia Package Manager OAuth token but no longer has the token stored locally. While previously it was possible to refetch the token from GitHub, this is no longer supported: https://developer.github.com/changes/2014-12-08-removing-authorizations-token/

This PR changes the github.jl code to always create a new token (with a different fingerprint) if a local token is not found.

@kshyatt kshyatt added the domain:packages Package management and loading label Aug 13, 2015
@wildart
Copy link
Member

wildart commented Aug 13, 2015

👍

@tkelman
Copy link
Contributor

tkelman commented Aug 13, 2015

removing code that's broken anyway sgtm

@slundberg
Copy link
Contributor Author

I noticed this never seemed to actually get merged. Was that intentional?

@IainNZ
Copy link
Member

IainNZ commented Oct 1, 2015

I thought this was merged too funny enough! Maybe rebase, if its still applicable?

@slundberg
Copy link
Contributor Author

I just pulled in all the new changes from master. There were a few minor conflicts, but nothing that changed the core reason for the PR.

@tkelman
Copy link
Contributor

tkelman commented Oct 1, 2015

It's preferable to rebase rather than merge for resolving conflicts, to avoid having too many unreviewable merge commits in the history.

Fixes Pkg.submit by removing code looking to fetch an existing token
from GitHub.
@slundberg
Copy link
Contributor Author

Sounds good. Now it is rebased.

@jiahao
Copy link
Member

jiahao commented Oct 1, 2015

Thanks! let's try it.

jiahao added a commit that referenced this pull request Oct 1, 2015
Fixes Pkg.submit(): GitHub no longer stores OAuth tokens
@jiahao jiahao merged commit 8518539 into JuliaLang:master Oct 1, 2015
@ivarne
Copy link
Sponsor Member

ivarne commented Oct 1, 2015

Seems like this is a prime candidate for Backporting (removing broken code).

@tkelman tkelman added this to the 0.4.1 milestone Oct 1, 2015
@tkelman
Copy link
Contributor

tkelman commented Oct 16, 2015

also backport 0d457dd with this

@tkelman
Copy link
Contributor

tkelman commented Oct 22, 2015

Whoops, we somehow never backported #6668 to release-0.3, so there are conflicts in cherry-picking there that I don't think are worth figuring out. Taking this off the "backport pending 0.3" list, but will leave on the 0.4.1 list.

tkelman pushed a commit that referenced this pull request Oct 31, 2015
Fixes Pkg.submit by removing code looking to fetch an existing token
from GitHub.

(cherry picked from commit db9141d)
ref #12607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:packages Package management and loading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants