Remove unexported, undocumented, and unused utf8sizeof and is_utf8_start from Base #12655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove new use of is_utf8_start
| @@ -26,10 +26,6 @@ const utf8_trailing = [ | |||
| 2,2,2,2,2,2,2,2,2,2,2,2,2,2,2,2, 3,3,3,3,3,3,3,3,4,4,4,4,5,5,5,5, | |||
| ] | |||
|
|
|||
| # Retained because although undocumented and unexported, used in a package (MutableStrings) | |||
There was a problem hiding this comment.
A PR or issue should probably be opened on MutableStrings since this package is mentioned explicitly.
jakebolewski
added a commit
that referenced
this pull request
Aug 17, 2015
Remove unexported, undocumented, and unused utf8sizeof and is_utf8_start from Base
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions were only used in packages, and not in Base.
I have already made a PR JuliaLang/JuliaParser.jl#21 to remove utf8sizeof.
I will make another PR to fix MutableStrings, but it hasn't been updated in 2 years.