Remove various string functions from flisp and support functions from utf8.c #12762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /* convert a string with literal \uxxxx or \Uxxxxxxxx characters to UTF-8 | ||
| example: u8_unescape(mybuf, 256, "hello\\u220e") | ||
| note the double backslash is needed if called on a C string literal */ | ||
| size_t u8_unescape(char *buf, size_t sz, const char *src) |
There was a problem hiding this comment.
I think there is an occurrence of this in utf8.h.
There was a problem hiding this comment.
Argh! That's what happens when I code at 40,000 feet! (the change was still in my editor, unsaved, and the compiler doesn't complain).
Fixed now, and I saw another function (and declaration!) to remove.
(string.width, string.encode, string.decode, string.split, char.upcase, char.downcase) Removed unused support functions in utf8.c and declarations in utf8.h (u8_codingsize, u8_unescape, u8_is_locale_utf8)
ScottPJones
force-pushed
the
spj/remstring
branch
from
d3e5e30
to
308cc33
Compare
JeffBezanson
added a commit
that referenced
this pull request
Aug 23, 2015
Remove various string functions from flisp and support functions from utf8.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed from flisp interpreter:
string.width,string.encode,string.decode,string.split,char.upcase,char.downcaseRemoved support functions in
utf8.cno longer used after removal:u8_codingsize,u8_unescape