Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing doc on macro "@~" #14653

Closed
wants to merge 2 commits into from
Closed

Fixed missing doc on macro "@~" #14653

wants to merge 2 commits into from

Conversation

yebai
Copy link

@yebai yebai commented Jan 12, 2016

No description provided.

@tkelman
Copy link
Contributor

tkelman commented Jan 14, 2016

@hayd why the close? The other PR was mistakenly against release-0.4 (do keep an eye out for PR's that unintentionally get opened that way). It would be good to squash these commits, and there's a decent chance we'll deprecate the ~ macro sooner or later, but for now this doesn't hurt.

@hayd
Copy link
Member

hayd commented Jan 14, 2016

oh, my bad!

Edit: Sorry about that!

@hayd hayd reopened this Jan 14, 2016
@yebai
Copy link
Author

yebai commented Jan 14, 2016

I very much hope the ~ macro do not get deprecated, which is a low-maintenance feature but turns out to be really helpful. For example, this macro has been used to implement statistical formulas (e.g. x ~ Normal(0, 1)) in packages like DataFrames.

@tkelman
Copy link
Contributor

tkelman commented Jan 14, 2016

See #11608 and JuliaStats/GLM.jl#116 - it's a non-extensible special case in the parser that "was introduced more-or-less for R compatibility" which isn't as important a design factor as it was early on when some of these features were first implemented. GLM and DataFrames could still use ~ for formula notation, but inside a macro DSL.

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jan 22, 2016

lgtm. would be nice to squash the commits when merging though

@vtjnash vtjnash closed this Jan 24, 2016
@vtjnash
Copy link
Sponsor Member

vtjnash commented Jan 24, 2016

committed as 70477b7

@yebai yebai deleted the patch-1 branch February 14, 2016 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants