Better SubArray support for strange indices #15144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix JuliaLang#15138. Additionally, ensure dispatch behaves properly for views of views.
|
👍 . Presumably you were motivated independently, but you may be interested in JuliaMath/Interpolations.jl#106. |
|
You're on to me! No, I hadn't seen that, but I've definitely had Interpolations and similar packages in mind. The path towards two Arraypocalypse check boxes got a lot easier with lispy SubArrays - full APL indexing and allowing all Numbers (#12567 (comment)) should just be a handful of changes each. |
|
Linux32 failed with a strange compilation error building libuv (log); I restarted it. |
|
Thanks for gisting the log. That's usually a sign that something in the deps cache was corrupt somehow. Anyway, lgtm. |
mbauman
added a commit
that referenced
this pull request
Feb 20, 2016
Better SubArray support for strange indices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15138. Additionally, ensure we dispatch to the proper method for views of views.