RFC: Add API for programatic tracing of specializations/new methods #15860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JeffBezanson thoughts on this change? |
| @@ -210,6 +210,7 @@ typedef struct _jl_lambda_info_t { | |||
| // and so unspecialized will be created for each linfo instead of once in linfo->def. | |||
| // 0 = no, 1 = yes, 2 = not yet known | |||
| uint8_t needs_sparam_vals_ducttape : 2; | |||
| uint8_t traced : 1; | |||
There was a problem hiding this comment.
Will need a comment explaining this field.
|
Yes, these are the only places where new methods and specializations are added. I guess we can just try this and see how it goes. |
This adds a new API that allows code to register two callbacks to be informed of new specializations/methods in the system: - jl_register_tracer, which will call the passed callback on any newly added specialization of a lambda info that has the `traced` flag set. - jl_register_newmeth_tracer, which will call the passed callback on any newly created method in the system.
|
I'll take that as "go ahead and merge". |
Keno
added a commit
that referenced
this pull request
Apr 16, 2016
Revert "Revert "Merge pull request #15860 from JuliaLang/kf/tracing""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose, hypothetically that some person may want to write a debugger for julia. In that case said person would want to be informed when new methods are added to the system such that they can be checked against any breakpoint conditions that the debugger may have. This adds a minimal such implementation that allows one to register a callback to be informed of such events. Potential points of design discussion:
@JeffBezanson