Make libssh stack more robust to rebuilds #17475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see https://cmake.org/Bug/view.php?id=14366, the cache was getting deleted because it thought CMAKE_C_COMPILER was changing, causing issues with missing destdir paths when doing the install
with libgit2, libssh2, and mbedtls - the dependencies are order-only '|' on CMakeLists.txt since applying the patches changes that file
tkelman
added
the
domain:building
|
i686-linux travis froze, log backed up to https://gist.github.com/0573e8ca6e7bf0e0bd7f5c138d77cb4a and restarted |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit messages, this should allow us to revert 854d905 and hopefully get the buildbots working more reliably since the merge of #17391
(we might want to generalize the LLVM_PATCH macro and use it everywhere at some point)