Fix utf8proc include path for flisp

[iblislin]

I got this error with USE_SYSTEM_UTF8PROC=1 and UTF8PROC_INC=/usr/local/include on branch release-0.4.

gmake[3]: Entering directory '/usr/home/iblis/git/fbsd-ports-julia/work/julia-0.4.6/src/flisp'
    CC src/array.o
    CC src/dump.o
    CC src/flisp/flisp.dbg.obj
    CC src/flisp/builtins.dbg.obj
    CC src/toplevel.o
    CC src/flisp/string.dbg.obj
string.c:23:10: fatal error: 'utf8proc.h' file not found
#include "utf8proc.h"
         ^
1 error generated.

A patch is here:

--- src/flisp/Makefile.orig     2016-08-01 06:13:50 UTC
+++ src/flisp/Makefile
@@ -32,7 +32,7 @@ LIBS += -lpthread
 endif

 FLAGS = -I$(LLTDIR) $(CFLAGS) $(HFILEDIRS:%=-I%) \
-        -I$(LIBUV_INC) -I$(build_includedir) $(LIBDIRS:%=-L%) \
+        -I$(LIBUV_INC) -I$(UTF8PROC_INC) -I$(build_includedir) $(LIBDIRS:%=-L%) \
         -DLIBRARY_EXPORTS -DUTF8PROC_EXPORTS
 ifneq ($(USEMSVC), 1)
 FLAGS += -Wall -Wno-strict-aliasing -DUSE_COMPUTED_GOTO -fvisibility=hidden

[tkelman]

Mind submitting that as a pull request?

[iblislin]

@tkelman ok, i can make it.

Should i cherry pick the commit to other branch or just master?

[tkelman]

If it's needed on both branches, make the PR against master first and we'll mark it for backporting to 0.4.

[tkelman]

Whoa, did you turn the issue into a PR? That requires some github api magic, right?

[iblislin]

@tkelman yep. I use hub pull-requrest -i <num> for converting it.

Some of my projects are using this workflow: someone open issue -> discussion -> attach a branch to this issue and convert it to a PR.
But github has announced that this feature will be deprecated in future. 😭