Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document use of sanitizers and provide default options #18067

Merged
merged 2 commits into from Aug 18, 2016
Merged

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Aug 16, 2016

The default options should allow a plain ./julia to work without any ASAN_OPTIONS required.

@kshyatt kshyatt added the domain:docs This change adds or pertains to documentation label Aug 17, 2016
@maleadt maleadt merged commit 3cbc05d into master Aug 18, 2016
@maleadt maleadt deleted the tb/asan_doc branch August 18, 2016 13:34
@tkelman
Copy link
Contributor

tkelman commented Aug 20, 2016

Does any of this documentation depend on things that are 0.6-only and haven't been backported?

@maleadt
Copy link
Member Author

maleadt commented Aug 20, 2016

It does. Do you think having 0.5 passing tests under ASAN is valuable? If so, I'll have look and mark the necessary PRs for backporting (including the stack-size part of @yuyichao's #17727).

@StefanKarpinski
Copy link
Sponsor Member

StefanKarpinski commented Aug 20, 2016

In general, we should endeavor to minimize the difference between the 0.5 branch and master for as long as we can. That means that any non-breaking, sufficiently safe change on master should be backported whenever possible. In short, yes, please do!

maleadt added a commit that referenced this pull request Aug 20, 2016
Document use of sanitizers and provide default options.
maleadt added a commit that referenced this pull request Aug 21, 2016
(cherry picked from commit 2d9f3a7, ref #18067)
maleadt added a commit that referenced this pull request Aug 21, 2016
(cherry picked from commit 030ff40, ref #18067)
maleadt added a commit that referenced this pull request Aug 21, 2016
(cherry picked from commit 2d9f3a7, ref #18067)
maleadt added a commit that referenced this pull request Aug 21, 2016
(cherry picked from commit 030ff40, ref #18067)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants