Avoid infinite method error on bootstrap error #18438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyichao
force-pushed
the
yyc/boot-metherr
branch
from
a999946
to
17e371f
Compare
yuyichao
force-pushed
the
yyc/boot-metherr
branch
from
17e371f
to
320b86d
Compare
|
is whatever this was fixing also an issue on release-0.5? |
|
It does. But this is a developer only feature. |
|
or if you do something wrong in userimg, right? |
|
No |
|
what would cause it then? will wait until 0.5.1 |
|
Raising an uncaught error before it can be shown or essentially anytime when something is broken, which is why I said this is a developer only feature. (In #18444 I think it was when I messed up some parameter packing for vararg functions in type inference). Might also fix hanging when pressing Ctrl-C too early in sysimg compilation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make the control flow in
exec_programeasier to understand.