type system revision and new subtype algorithm #18457
Merged
Commits on Jan 16, 2017
-
- update for v0.5 - an algorithm improvement for vars that match unions
-
add tests for type intersection fully move subtyping tests from test/core to test/subtype [ci skip]
-
new type union, unionall representation, new subtype and intersection…
… algorithms [ci skip]
-
-
make type declarations with triangular constraints work properly
e.g. fixes #6721 fixes to type instantiation get several test suites passing remove ambiguous `convert` definition add some disambiguating definitions for sparse `map` fix a method ambiguity in RowVector fix check for iterability in Dict constructor [ci skip]
-
normalize
Tuple{Vararg}toTupleotherwise, `Tuple{Vararg{T} where T}` is not really a meaningful type -
make ordered type cache more robust
Allow multiple entries that are equal according to the ordered comparison predicate typekey_compare, but not equal according to jl_types_equal. This is mostly needed for types in replaced modules, which can be distinguished by pointer comparison but cannot be reliably ordered (since they differ only in memory address).
-
-
-
-
remove extraneous for loops for subtype algo
fold the "more" flag into the first iteration of subtyping
-
-
add a fastpath to type-equal for leaftype
this is important because it is on the inner loop for `jl_inst_concrete_tupletype` (aka `jl_f_tuple`)
-
-
use Const(T) instead of Type{T} in inference
since Type{T} is not a singleton object (Type{T}.parameters[1] !== T) we need to avoid assuming it can be used as a representation of a constant type this change also allows deferring allocation of as many Type{T} objects in the type cache, which is expected to be overall beneficial (independent of fixing the aforementioned bug) this necessitated a change to `associative_with_eltype` to allow inference to prove that the object passed to DT is always the same constant, and not just type-equal to it -
return_type_tfunc was too pessimistic
make Union{} a leaftype (and also Tuples of Unions) and ensure return_type_tfunc will infer as much as possible -
-
Fix the instance of assuming DataType that caused the crash in array.c and audit other uses, inserting appropriate assertions.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.