Fix reflection test failure on 32bit #19885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug here is that one of the pointers gets zero extended (isymb->first), while the other (Fptr) gets sign extended, so comparing the two breaks down. The simplest way to fix, is just to use the appropriate integer size for the platform we're on.
|
So why is it we weren't hitting this as an issue until recently? |
|
Well, the bug only shows up if you have two jumps into the same function (and the address of the generated code is in the upper 2GB of address space), so it depends on the generated code, and perhaps even the way the OS decides to allocate memory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug here is that one of the pointers gets zero extended (isymb->first),
while the other (Fptr) gets sign extended, so comparing the two breaks down.
The simplest way to fix, is just to use the appropriate integer size for the
platform we're on.
Fixes #19803.