minimal hook into loading necessary for Pkg3 #20008
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
reviewed
Jan 13, 2017
| @@ -32,9 +32,9 @@ isinteractive() = (is_interactive::Bool) | |||
|
|
|||
| An array of paths (as strings) where the `require` function looks for code. | |||
tkelman
reviewed
Jan 13, 2017
| let paddedname = "Ztest_sourcepath.jl" | ||
| filename = SubString(paddedname, 2, length(paddedname)) | ||
| @test Base.find_in_path(filename) == abspath(paddedname[2:end]) | ||
| empty!(LOAD_PATH) |
There was a problem hiding this comment.
should probably restore prior value when done?
tkelman
reviewed
Jan 13, 2017
| @@ -720,6 +720,12 @@ Get the name of a generic `Function` as a symbol, or `:anonymous`. | |||
| """ | |||
| function_name(f::Function) = typeof(f).name.mt.name | |||
|
|
|||
| function find_source_file(file::String) | |||
There was a problem hiding this comment.
does this get called on package code?
There was a problem hiding this comment.
No, it's only used in this file and, as far as I can tell, doesn't actually rely on find in path behavior at all in practice anymore.
There was a problem hiding this comment.
calling edit on a method from a package?
tkelman
reviewed
Jan 13, 2017
|
|
||
| # `wd` is a working directory to search. defaults to current working directory. | ||
| # if `wd === nothing`, no extra path is searched. | ||
| function find_in_path(name::String, wd) |
There was a problem hiding this comment.
Blink, PkgDev, and node-julia are using the 2 arg version of this. And ClobberingReload is using find_in_node_path. deprecate?
There was a problem hiding this comment.
Ok, will do.
StefanKarpinski
force-pushed
the
sk/loadhook
branch
from
0851bf6
to
e655337
Compare
tkelman
suggested changes
Jan 14, 2017
This is used by the generic Base.find_in_path function to look up a name in each successive entry in [Pkg.dir(); LOAD_PATH]. In this commit, this doesn't allow any custom loading since LOAD_PATH can still only contain values of type String.
To implement custom module loading, define Base.load_hook method for a custom type that returns a path to the file to be loaded. This mechanism can, for example, be used to allow Pkg3 to hook into code loading, organizing files quite differently from Base. Note that unlike standard LOAD_PATH search, which uses the first possible path found, custom mechanisms can continue searching.
StefanKarpinski
force-pushed
the
sk/loadhook
branch
from
e655337
to
9bdf42e
Compare
|
Closed in favor of #20120 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a less disruptive alternative to #19910 and #19866. Doesn't really change anything, just makes how code gets loaded extensible via putting things that aren't Strings in
LOAD_PATHand defining appropriate methods forBase.load_hook.It does also remove searching for files relative to the current directory behavior, but I don't think that was used by anything except for the reflection code, I've now factored out.