Remove multidimensional indexing of tuples #20468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
added
the
domain:collections
|
It looks like the method was added in #16986. @pabloferz, do you know what in particular that method was for? I couldn't find any actual uses of it in the multidimensional code. |
|
Previously a method for tuples existed which permited multidimensional indexing. However, the method merely splatted the dimensions and ended up calling itself, infinitely recursing. This commit replaces the method with one that permits the desired behavior for broadcast without permitting things like (1,)[1,1].
ararslan
force-pushed
the
aa/tuple-indexing
branch
from
a2d8244
to
9212ca6
Compare
|
Aha, I should have known! Thanks for your help. I've replaced the method with one for Cartesian indexing. It would be great if you could take a look, since you're more familiar with the |
pabloferz
approved these changes
Feb 6, 2017
StefanKarpinski
approved these changes
Feb 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a method for tuples exists which permits multidimensional indexing (see #20453). The method merely splats the dimensions and ends up inadvertently calling itself recursively, as there's no more specific method for it to use. This PR simply removes the method and adds tests to ensure the behavior doesn't return.
Fixes #20453