Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sharedarray: improve error msg on bsd family #20757

Merged
merged 1 commit into from
Feb 24, 2017
Merged

sharedarray: improve error msg on bsd family #20757

merged 1 commit into from
Feb 24, 2017

Conversation

iblislin
Copy link
Member

No description provided.

tkelman
tkelman reviewed Feb 23, 2017
View reviewed changes
base/sharedarray.jl Outdated
else
# seems NetBSD do not have *.shmall
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not have

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@tkelman tkelman added the system:freebsd Affects only FreeBSD label Feb 23, 2017
tkelman
tkelman approved these changes Feb 23, 2017
View reviewed changes
Copy link
Contributor

@tkelman tkelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for all these improvements - great to get our freebsd support polished up that last little bit

@JeffBezanson JeffBezanson merged commit f95bc77 into JuliaLang:master Feb 24, 2017
@iblislin iblislin deleted the bsd-sharedarr branch February 24, 2017 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sacha0 Sacha0 Sacha0 approved these changes

@tkelman tkelman tkelman approved these changes

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
system:freebsd Affects only FreeBSD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@iblislin @Sacha0 @tkelman @ararslan @JeffBezanson