Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct file separator on windows for constants in build_h.jl #22416

Merged
merged 2 commits into from Jul 11, 2017
Merged

Use correct file separator on windows for constants in build_h.jl #22416

merged 2 commits into from Jul 11, 2017

Conversation

musm
Copy link
Contributor

@musm musm commented Jun 18, 2017

close #21330

tkelman
tkelman reviewed Jun 18, 2017
View reviewed changes
test/osutils.jl Outdated
@@ -26,3 +26,13 @@ end
@test (@static false && 1) === false
@test (@static true || 1) === true
@test (@static false || 1) === 1

# test that path variables use proper path deliminter on windows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delimiter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks,fixed

@ararslan ararslan added the windows Affects only Windows label Jun 18, 2017
@musm
Copy link
Contributor Author

musm commented Jun 19, 2017 •
edited

cc @vtjnash does this look good?

@musm
Copy link
Contributor Author

musm commented Jun 24, 2017

bump

@musm
Copy link
Contributor Author

musm commented Jul 2, 2017

Bump

nalimilan
nalimilan approved these changes Jul 3, 2017
View reviewed changes
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert in Makefiles nor of Windows, but this looks good to me, and since tests passed...

@musm
Copy link
Contributor Author

musm commented Jul 6, 2017

thanks @nalimilan , is this good to go in this case?

@StefanKarpinski StefanKarpinski merged commit 73efb99 into JuliaLang:master Jul 11, 2017
@musm musm deleted the relp branch July 11, 2017 16:27
jeffwong pushed a commit to jeffwong/julia that referenced this pull request Jul 24, 2017
@musm @jeffwong
Use correct file separator on windows for constants in build_h.jl (Ju…
8bccde1 
…liaLang#22416)
@coveralls
Copy link

Coverage Status

Coverage decreased (-10.2%) to 76.84% when pulling 5270ad5 on musm:relp into 3a17af0 on JuliaLang:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkelman tkelman tkelman left review comments

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
windows Affects only Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base.DATAROOTDIR file separator on windows
6 participants
@musm @coveralls @nalimilan @tkelman @StefanKarpinski @ararslan