Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove .jl extension in Pkg.update #23214

Merged
merged 2 commits into from
Aug 12, 2017
Merged

remove .jl extension in Pkg.update #23214

merged 2 commits into from
Aug 12, 2017

Conversation

fredrikekre
Copy link
Member

Missed this in #20681, fix #23212

@fredrikekre fredrikekre added backport pending 0.6 domain:packages Package management and loading labels Aug 11, 2017
@tkelman tkelman added the needs tests Unit tests are required for this change label Aug 11, 2017
@fredrikekre
Copy link
Member Author

Added a test, it's a simple one, but at least it test that it does not error.
Side note: CI is all green for the first commit, haven't seen that in a long time 🎉

Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fredrikekre! :)

@tkelman tkelman removed the needs tests Unit tests are required for this change label Aug 11, 2017
@tkelman
Copy link
Contributor

tkelman commented Aug 11, 2017

Travis increased our timeout by half an hour, and gave us 50% more capacity for a week. But apparently the tests on 32 bit linux are so slow that we need all of that time and this came very close to timing out there.

@fredrikekre fredrikekre merged commit 4c5cc04 into master Aug 12, 2017
@fredrikekre fredrikekre deleted the fe/jlext branch August 12, 2017 13:47
ararslan pushed a commit that referenced this pull request Sep 11, 2017
* remove .jl extension in Pkg.update

* add test

Ref #23214
(cherry picked from commit 4c5cc04)
ararslan pushed a commit that referenced this pull request Sep 13, 2017
* remove .jl extension in Pkg.update

* add test

(cherry picked from commit 4c5cc04)
vtjnash pushed a commit that referenced this pull request Sep 14, 2017
* remove .jl extension in Pkg.update

* add test

(cherry picked from commit 4c5cc04)
ararslan pushed a commit that referenced this pull request Sep 15, 2017
* remove .jl extension in Pkg.update

* add test

(cherry picked from commit 4c5cc04)
ararslan pushed a commit that referenced this pull request Sep 16, 2017
* remove .jl extension in Pkg.update

* add test

(cherry picked from commit 4c5cc04)
ararslan pushed a commit that referenced this pull request Sep 18, 2017
* remove .jl extension in Pkg.update

* add test

(cherry picked from commit 4c5cc04)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:packages Package management and loading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent handling of ".jl" in package manager functions
4 participants