Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate float(::String) #24220

Merged
merged 1 commit into from Oct 20, 2017
Merged

Deprecate float(::String) #24220

merged 1 commit into from Oct 20, 2017

Conversation

ararslan
Copy link
Member

Fixes #24219

@ararslan ararslan added the kind:deprecation This change introduces or involves a deprecation label Oct 19, 2017
KristofferC
KristofferC reviewed Oct 19, 2017
View reviewed changes
base/deprecated.jl Outdated
@@ -1893,6 +1893,10 @@ end
# issue #24006
@deprecate linearindices(s::AbstractString) eachindex(s)

# Issue 24219
@deprecate float(x::AbstractString) parse(Float64, x)
@deprecate float(a::AbstractArray{<:AbstractString}) map(x->parse(Float64, x), a)
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parse.(Float64, a)?

@ararslan ararslan merged commit 218c6c9 into master Oct 20, 2017
@ararslan ararslan deleted the aa/deprecate-float branch October 20, 2017 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC KristofferC left review comments

@JeffBezanson JeffBezanson JeffBezanson approved these changes

@fredrikekre fredrikekre fredrikekre approved these changes

Assignees
No one assigned
Labels
kind:deprecation This change introduces or involves a deprecation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ararslan @JeffBezanson @KristofferC @fredrikekre