Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace Array{...}(shape...)-like calls in test/linalg #24712

Merged
merged 1 commit into from
Nov 23, 2017
Merged

replace Array{...}(shape...)-like calls in test/linalg #24712

merged 1 commit into from
Nov 23, 2017

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Nov 22, 2017 •
edited
Loading

This pull request replaces Array{...}(shape...)-like calls in test/linalg. Ref. #24595. Best!

@Sacha0 Sacha0 added the domain:arrays [a, r, r, a, y, s] label Nov 22, 2017
fredrikekre
fredrikekre approved these changes Nov 22, 2017
View reviewed changes
Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these all such calls in test/linalg? Surprisingly few ...

@Sacha0
Copy link
Member Author

Sacha0 commented Nov 22, 2017

Are these all such calls in test/linalg? Surprisingly few ...

All beginning Array{. Others inbound :).

@Sacha0
Copy link
Member Author

Sacha0 commented Nov 23, 2017 •
edited
Loading

Updated including those calls beginning Vector{ and Matrix{ (surprisingly few). Best!

@Sacha0 Sacha0 changed the title replace Array{...}(shape...) with uninitialized-accepting equivalents in test/linalg replace Array{...}(shape...)-like calls in test/linalg Nov 23, 2017
@Sacha0 Sacha0 merged commit 15a5aeb into JuliaLang:master Nov 23, 2017
@Sacha0
Copy link
Member Author

Sacha0 commented Nov 23, 2017

Thanks all! :)

@Sacha0 Sacha0 deleted the reparrtlinalg branch November 23, 2017 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre approved these changes

Assignees
No one assigned
Labels
domain:arrays [a, r, r, a, y, s]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sacha0 @fredrikekre