Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Unicode-related functions to new Unicode stdlib package #25021

Merged
merged 3 commits into from
Dec 13, 2017
Merged

Move Unicode-related functions to new Unicode stdlib package #25021

merged 3 commits into from
Dec 13, 2017

Commits on Dec 12, 2017

  1. Move Unicode-related functions to new Unicode stdlib package 

    Keep them under Base.Unicode since they are needed inside Base,
but stop exporting them to Base since they would conflict with
the deprecations. Base.Unicode is the new name for Base.UTF8proc,
but including a few more functions.
    @nalimilan
    nalimilan committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    e62ab28 View commit details
    Browse the repository at this point in the history

  2. Rename base/strings/utf8proc.jl to base/strings/unicode.jl 

    To match the new name of the module.
    @nalimilan
    nalimilan committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    635826b View commit details
    Browse the repository at this point in the history

  3. Deprecate isnumber(), is_assigned_char() and normalize_string() 

    isnumeric() is consistent with Python and Rust (but not Go), and less easy to confuse
with isdigit(). Improve documentation to make confusion less easy. Also fix a few uses
where isdigit() is more appropriate than isnumber().
    @nalimilan
    nalimilan committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    756936a View commit details
    Browse the repository at this point in the history