Move back isascii() from Unicode to Base #25076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnj
approved these changes
Dec 14, 2017
|
Looks like there's already a conflict though |
This function is not really Unicode-related and its definition does not depend on the Unicode standard version. This fixes a bug introduced when moving isascii() to Base.Unicode, as it was not exported from Unicode stdlib module as it should have been.
nalimilan
force-pushed
the
nl/isascii
branch
from
61ac4f2
to
dd17209
Compare
|
Will |
|
I don't think so. Why define a function in two places? |
|
¯\_(ツ)_/¯ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is not really Unicode-related and its definition does not depend on the Unicode standard version. This fixes a bug introduced when moving
isasciitoBase.Unicode(#25021), as it was not exported fromUnicodestdlib module as it should have been.Fixes #25075.