Stateful: fix major bug in implementation #27972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
force-pushed
the
jn/Stateful-26339-26417
branch
from
69428f1
to
00cfbb2
Compare
|
Was this a behavioral bug or a performance bug? |
|
Implementation looks fine to me, but it's a bit odd that the commit message says this fixes a bug in Stateful, when neither of the bugs it fixes uses Stateful. |
|
Behavioral bug. |
vtjnash
force-pushed
the
jn/Stateful-26339-26417
branch
from
00cfbb2
to
81b9990
Compare
vtjnash
force-pushed
the
jn/Stateful-26339-26417
branch
from
81b9990
to
92856dc
Compare
Missed optimizations introduced when the type lattice was changed by:
commit 146c2ba
Author: Keno Fischer <keno@alumni.harvard.edu>
Date: Tue Jan 16 13:56:21 2018 -0500
Fix backpropagation of conditionals when the type is later widened
vtjnash
force-pushed
the
jn/Stateful-26339-26417
branch
from
92856dc
to
068bf3d
Compare
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And re-tighten Inference information for Const boolean converted to Conditional
fix #26417
fix #26339