WIP/RFC: extend date formats with markers for optional and fixed length markers #28741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
added
kind:breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests changes the behavior of parsing dates that currently doesn't error when reaching the end of a string. It introduces
[...]to mark optional parts that do not have to come at the end. The formaty m dwould become[y[ [m[ [d]]]]]. It's much longer but my guess is that mandatory parts are wanted more often.Previously parts only had fixed length when they were not separated from the next part. This detection is replaced by
!to mark fixed length.Formats like
yyyy![mm!]dd!do not work because there is no rollback after an optional part has been successfully.These changes would help with #28090 and #26962.