Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve all method ambiguities in LinearAlgebra #28749

Merged
merged 3 commits into from
Aug 21, 2018
Merged

Resolve all method ambiguities in LinearAlgebra #28749

merged 3 commits into from
Aug 21, 2018

Commits on Aug 19, 2018

  1. Add a test to check method ambiguities

    @tkf
    tkf committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    efbd9a4 View commit details
    Browse the repository at this point in the history

  2. Use StridedMatrix to avoid method ambiguity; fixes JuliaLang#27405

    @tkf
    tkf committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    a93f1fc View commit details
    Browse the repository at this point in the history

  3. Avoid method ambiguity in promote_leaf_eltypes 

    This change is only for making Test.detect_ambiguities and shouldn't
introduce any change in working code (unless it depends on MethodError).

Before this change, we have:

julia> LinearAlgebra.promote_leaf_eltypes(())
ERROR: MethodError: LinearAlgebra.promote_leaf_eltypes(::Tuple{}) is ambiguous. Candidates:

With this change, we have:

julia> LinearAlgebra.promote_leaf_eltypes(())
Bool
    @tkf
    tkf committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    c8b8935 View commit details
    Browse the repository at this point in the history