fix #29885, make grisu digit buffer task-local #29907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
I/O
vtjnash
approved these changes
Nov 2, 2018
| @async print(q, 9.8) | ||
| read(p, 2^18) | ||
| @test read(p, String) == "12.345" | ||
| end |
There was a problem hiding this comment.
wrap in @sync (so we'll collect any errors)
JeffBezanson
force-pushed
the
jb/fix29885
branch
from
f07d01e
to
0a427a3
Compare
stevengj
approved these changes
Nov 8, 2018
|
I think we need to do the same thing for |
|
Do task-blocking operations happen while BIGNUMS is still in use? |
|
What operations are task-blocking? |
|
I/O, sleep, calls to |
|
Will add news separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought task-local storage might be too slow for this, but fortunately the slowdown is only about 5-6%. I also tried per-thread pools but it wasn't faster. Hopefully TLS access can be sped up a bit too.
Note: I kept the existing global
DIGITSin place since I believe some packages use it.fix #29885