Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Regex a scalar in broadcasting #29913

Merged
merged 2 commits into from Nov 7, 2018

Conversation

4 participants
@fredrikekre
Copy link
Member

commented Nov 2, 2018

@fredrikekre fredrikekre requested a review from mbauman Nov 2, 2018

@StefanKarpinski

This comment has been minimized.

Copy link
Member

commented Nov 2, 2018

Diff best seen ignoring whitespace; related: don't squash since there's a testset-introducing commit.

@mbauman

mbauman approved these changes Nov 2, 2018

@mbauman

This comment has been minimized.

Copy link
Member

commented Nov 2, 2018

Ref #29250 (would close it if it weren't already closed).

@fredrikekre fredrikekre force-pushed the fe/regex branch from 9c4dd71 to 492018f Nov 3, 2018

@fredrikekre

This comment has been minimized.

Copy link
Member Author

commented Nov 3, 2018

Had to move the definition from regex.jl to broadcast.jl for bootstrapping reasons.

@fredrikekre fredrikekre force-pushed the fe/regex branch from 492018f to b7d7bb9 Nov 5, 2018

@fredrikekre fredrikekre added broadcast and removed needs news labels Nov 5, 2018

@fredrikekre fredrikekre merged commit 1be7fa5 into master Nov 7, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
julia freebsd ci Build done
Details

@fredrikekre fredrikekre deleted the fe/regex branch Nov 7, 2018

@mbauman mbauman removed the needs news label Nov 7, 2018

@KristofferC

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2018

Missed that, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.