Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Fix #31392, unaliasing of broadcast arguments against destinations with repeated indices #31407

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Apr 27, 2020

  1. Fix #31392, unaliasing of broadcast arguments against destinations wi…

    …th repeated indices
    
    When introducing the new broadcasting implementation (which came alongside greater
    semantic guarantees with regards to aliasing source and destination), I found that
    we needed a performance optimization for the common case where the destination was
    `===` to an argument. This is quite common due to the `.op=` syntax and indeed is
    safe in most cases as the iteration order between the destination and the source
    is matched. This performance optimization is not safe, however, in the case that
    the destination has multiple locations that refer to the same memory.
    mbauman committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    7a3cdb1 View commit details
    Browse the repository at this point in the history
  2. Be more optimistic about the world

    but still provide the hook for arrays to improve
    mbauman committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    55e10b2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    347cabf View commit details
    Browse the repository at this point in the history

Commits on May 7, 2021

  1. Configuration menu
    Copy the full SHA
    e4f54ca View commit details
    Browse the repository at this point in the history