Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Faster implementation of Float64(::BigInt) #31501

Closed
wants to merge 1 commit into from
Closed

WIP: Faster implementation of Float64(::BigInt) #31501

wants to merge 1 commit into from

Conversation

narendrakpatel
Copy link
Contributor

#31293
Implements 64-bit version of conversion

Work remaining:

  • 32-bit version
  • code cleanup

@narendrakpatel narendrakpatel deleted the np/bigint-to-float branch March 27, 2019 17:40
@narendrakpatel narendrakpatel restored the np/bigint-to-float branch March 27, 2019 17:41
@simonbyrne
Copy link
Contributor

for future reference, you can update the branch the pull request is based on, you don't need to open new ones.

@narendrakpatel
Copy link
Contributor Author

Clarification: I closed this as I had mistakenly opened a PR rather than a Draft PR. I will make sure that I do not make mistakes like that again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@narendrakpatel @simonbyrne