hypot behaves like L2-norm, adjust the docstring to reflect this
#31947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
commented
May 6, 2019
stevengj
approved these changes
May 7, 2019
|
Bump 😃 |
|
I’m not at my computer at the moment: what’s the issue with all the broken tests? |
|
AppVeyor on x86_64 failed to download a file, buildbot on win32 has an sha512sum hash mismatch in another download. I don't think they're related to the new tests added by this PR. |
|
Sorry, I meant all the new |
|
I'm not a huge fan of bundling the unrelated tests with the docstring changes. Can you move them to a separate PR? Also, a lot of the |
|
I've completely removed the tests from this PR, only the docstring change is here |
StefanKarpinski
approved these changes
May 20, 2019
|
Bump 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #31941. Here it was agreed that the current behaviour of
hypotis correct, but the docstring didn't match it.I also took the occasion to add a bunch of tests for
hypot. They've been shamelessly copied from #30301.