@cfunction: swap argument names for at, rt #33267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swap at (types of arguments) and rt (return value type).
|
Why? I am afraid we can't make this change because it changes an exported API. |
This is just changing the argument names. |
|
Yeah as it stands the argument names are backwards from how the macro is documented. |
|
Nevermind me then |
pemryan
changed the title
|
Very confusing atm when looking at this method. |
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
swap at (types of arguments) and rt (return value type).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swap at (types of arguments) and rt (return value type).