Define push! and popfirst! for AbstractChannel #34274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as it is not a subtype of AbstractChannel
|
@tkf looks like this needs a rebase. Could we get a review on this? |
|
Friendly bump :) |
StefanKarpinski
added
the
status:triage
JeffBezanson
approved these changes
Jul 16, 2020
JeffBezanson
added
the
status:merge me
|
Sorry about the long delay here. Triage approves. If you dust this off and it passes CI, we can merge it. |
DilumAluthge
removed
the
status:merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines
julia/base/channels.jl
Lines 10 to 11 in a143db1
which are previously only defined for
Channel.This PR also fixes the inconsistency of
push!(c::Channel, v)as reported in #34202; i.e.,push!(c::Channel, v)now returns the first argumentclike any other containers.close #34202