Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In open(f, ...), call flush before calling close #35303

Closed
wants to merge 2 commits into from
Closed

In open(f, ...), call flush before calling close #35303

wants to merge 2 commits into from

Commits on Mar 30, 2020

  1. In open(f, ...), call flush before calling close 

    In #35217, I noticed that if we call `close` on an IOStream, but the device
that has the underlying file is full, we silently truncate the file without
error. To remidy that, introduce an explicit flush call before closing the
file. This should either succeed and reflect the changes on disk, or fail
and throw an appropriate error.
    @Keno
    Keno committed Mar 30, 2020
    Copy the full SHA
    a9d9b3d View commit details
    Browse the repository at this point in the history

  2. Update base/io.jl 

    Co-Authored-By: Jameson Nash <vtjnash@gmail.com>
    @Keno @vtjnash
    Keno and vtjnash committed Mar 30, 2020
    Copy the full SHA
    b753750 View commit details
    Browse the repository at this point in the history