Fix minimum and maximum in the presence of missing values #35989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
commented
May 23, 2020
base/reduce.jl
Outdated
| v2 == v2 || return v2 | ||
| v3 == v3 || return v3 | ||
| v4 == v4 || return v4 | ||
| # === true is there to ignore missing |
There was a problem hiding this comment.
"ignore" isn't the right term actually since we short-circuit. I can change this to just add "or missing" to the existing comment for NaN.
There was a problem hiding this comment.
Just say something like "to handle missing"
There was a problem hiding this comment.
Actually "short-circuit" is even more accurate I think.
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
…35989) * Fix minimum and maximum in the presence of missing values * Fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another, possibly cleaner way of fixing this would be to add an
isnan(::Number) = falsefallback, and dox isa Number && isnan(x). That would make the code a bit clearer and could be useful for others. Currently we would have to dox isa Union{Real, Complex} && isnan(x)since there are the only types for which we defineisnanmethods -- but that approach wouldn't work for custom complex types.Similar to #35323 (but simpler to fix).