Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support init keyword in sum/prod/maximum/minimum #36188

Merged
merged 26 commits into from Jun 11, 2020
Merged

Support init keyword in sum/prod/maximum/minimum #36188

merged 26 commits into from Jun 11, 2020

Commits on May 11, 2020

  1. Support init keyword in maximum/minimum

    @timholy
    timholy committed May 11, 2020
    Copy the full SHA
    ed1cfc9 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. Add init keyword argument to sum and prod

    @tkf
    tkf committed Jun 8, 2020
    Copy the full SHA
    a9fd8b8 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/teh/reduce_init' into sum-init

    @tkf
    tkf committed Jun 8, 2020
    Copy the full SHA
    16b13d2 View commit details
    Browse the repository at this point in the history

  3. Test sum and prod

    @tkf
    tkf committed Jun 8, 2020
    Copy the full SHA
    72d01c0 View commit details
    Browse the repository at this point in the history

  4. Add compat annotations to minimum and maximum

    @tkf
    tkf committed Jun 8, 2020
    Copy the full SHA
    c3e66a5 View commit details
    Browse the repository at this point in the history

  5. Tweak docstring signature style

    @tkf
    tkf committed Jun 8, 2020
    Copy the full SHA
    31feb69 View commit details
    Browse the repository at this point in the history

  6. Fix reflection doctest

    @tkf
    tkf committed Jun 8, 2020
    Copy the full SHA
    32e0c99 View commit details
    Browse the repository at this point in the history

  7. Add a NEWS item

    @tkf
    tkf committed Jun 8, 2020
    Copy the full SHA
    b8a686b View commit details
    Browse the repository at this point in the history

  8. Fix sum(::AbstractArray{Bool}; dims)

    @tkf
    tkf committed Jun 8, 2020
    Copy the full SHA
    749e2ce View commit details
    Browse the repository at this point in the history

  9. Fix a typo

    @tkf
    tkf committed Jun 8, 2020
    Copy the full SHA
    bf551a7 View commit details
    Browse the repository at this point in the history

  10. Fix sum(::AbstractArray{Bool}) optimization path

    @tkf
    tkf committed Jun 8, 2020
    Copy the full SHA
    e1173cb View commit details
    Browse the repository at this point in the history

  11. Apply suggestions from code review 

    Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
Co-authored-by: Tim Holy <tim.holy@gmail.com>
    @tkf @nalimilan @timholy
    3 people committed Jun 8, 2020
    Copy the full SHA
    791f93c View commit details
    Browse the repository at this point in the history

  12. Reflect the same changes to other docstrings

    @tkf
    tkf committed Jun 8, 2020
    Copy the full SHA
    2b84499 View commit details
    Browse the repository at this point in the history

  13. Mention how nothing is used in the test

    @tkf
    tkf committed Jun 8, 2020
    Copy the full SHA
    2122e0e View commit details
    Browse the repository at this point in the history

  14. Demonstrate init for sum and prod

    @tkf
    tkf committed Jun 8, 2020
    Copy the full SHA
    6918213 View commit details
    Browse the repository at this point in the history

  15. Reflect the same changes to other docstrings (2)

    @tkf
    tkf committed Jun 8, 2020
    Copy the full SHA
    ea2cc8b View commit details
    Browse the repository at this point in the history

  16. Use function noncallable end

    @tkf
    tkf committed Jun 8, 2020
    Copy the full SHA
    32d7f93 View commit details
    Browse the repository at this point in the history

  17. Use init=Inf for minimum docstring

    @tkf
    tkf committed Jun 8, 2020
    Copy the full SHA
    3e7b09c View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
    @tkf @nalimilan
    tkf and nalimilan committed Jun 9, 2020
    Copy the full SHA
    0791d49 View commit details
    Browse the repository at this point in the history

  2. Revert: maximum(length, []; init=-1)

    @tkf
    tkf committed Jun 9, 2020
    Copy the full SHA
    923bbd8 View commit details
    Browse the repository at this point in the history

  3. Use typemax(Int64) for minimum(length, []; init=typemax(Int64))

    @tkf
    tkf committed Jun 9, 2020
    Copy the full SHA
    0050d4f View commit details
    Browse the repository at this point in the history

  4. Yet another example: minimum(tanh, Real[]; init=1.0)

    @tkf
    tkf committed Jun 9, 2020
    Copy the full SHA
    6951b2c View commit details
    Browse the repository at this point in the history

  5. Yet another example: maximum(tanh, Real[]; init=-1.0)

    @tkf
    tkf committed Jun 9, 2020
    Copy the full SHA
    04c0cc9 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
    @tkf @nalimilan
    tkf and nalimilan committed Jun 10, 2020
    Copy the full SHA
    5d952ec View commit details
    Browse the repository at this point in the history

  2. A short note on the output bound of tanh

    @tkf
    tkf committed Jun 10, 2020
    Copy the full SHA
    42a0155 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2020

  1. Use sin instead of tanh

    @tkf
    tkf committed Jun 11, 2020
    Copy the full SHA
    254a7cb View commit details
    Browse the repository at this point in the history